Profile field gets deleted everytime I update it in ACP

[baerenwurm]

Hi.

Everytime I update a user's profile - even when I just submit the form without any changes - the contents of one of my custom profile fields ($music) gets deleted.

--> admin_users.php

--> usercp_register.php

Updating profiles via profile.php works fine.

I hope there is still someone around willing to help me out

Thanks a lot!

[Patrick]

Hey baerenwurm,

What was the hack that you used to create the custom profile field? This might help others to help you.

Thanks,

Patrick

[baerenwurm]

Thanks for your quick reply!

I didn't use any specific hack, I just followed the instructions on phpbb.com, similar to these: http://www.phpbbhacks.com/download/5249

[Thoul]

Those files look okay to me, but the problem could be in the validate_optional_fields() function. It's in another file; includes/functions_validate.php, if I remember correctly.

[baerenwurm]

Hi.

Thanks again for helping me out here.

That's the relevant part in functions_validate.php:

Code: Select all

//
// Does supplementary validation of optional profile fields. This expects common stuff like trim() and strip_tags()
// to have already been run. Params are passed by-ref, so we can set them to the empty string if they fail.
//
function validate_optional_fields(&$icq, &$aim, &$msnm, &$yim, &$website, &$location, &$occupation, &$interests, &$movies, &$director, &$actor, &$music, &$dvdprofiler, &$sig)
{
	$check_var_length = array('aim', 'msnm', 'yim', 'location', 'occupation', 'interests', 'movies', 'actor', 'director', 'music', 'sig');

	for($i = 0; $i < count($check_var_length); $i++)
	{
		if (strlen($$check_var_length[$i]) < 2)
		{
			$$check_var_length[$i] = '';
		}
	}

	// ICQ number has to be only numbers.
	if (!preg_match('/^[0-9]+$/', $icq))
	{
		$icq = '';
	}
	
	// website has to start with http://, followed by something with length at least 3 that
	// contains at least one dot.
	if ($website != "")
	{
		if (!preg_match('#^http[s]?:\/\/#i', $website))
		{
			$website = 'http://' . $website;
		}

		if (!preg_match('#^http[s]?\\:\\/\\/[a-z0-9\-]+\.([a-z0-9\-]+\.)?[a-z]+#i', $website))
		{
			$website = '';
		}
	}

	if ($dvdprofiler != "")
	{
		if (!preg_match('#^http[s]?:\/\/#i', $dvdprofiler))
		{
			$dvdprofiler = 'http://' . $dvdprofiler;
		}

		if (!preg_match('#^http[s]?\\:\\/\\/[a-z0-9\-]+\.([a-z0-9\-]+\.)?[a-z]+#i', $dvdprofiler))
		{
			$dvdprofiler = '';
		}
	}

	return;
}

?>

[Thoul]

Yep, I see the problem now. There are three lines you need to look at, one in each file.

admin_users.php:

Code: Select all

validate_optional_fields($icq, $aim, $msn, $yim, $website, $dvdprofiler, $location, $occupation, $interests, $movies, $actor, $director, $music, $signature);

usercp_register.php:

Code: Select all

validate_optional_fields($icq, $aim, $msn, $yim, $website, $location, $occupation, $interests, $movies, $actor, $director, $music, $dvdprofiler, $signature);

functions_validate.php:

Code: Select all

function validate_optional_fields(&$icq, &$aim, &$msnm, &$yim, &$website, &$location, &$occupation, &$interests, &$movies, &$director, &$actor, &$music, &$dvdprofiler, &$sig) 

Notice how the variables are in a different order on each line. For instance, $music is second to last on the first and third to last on the others. That's your problem. The variable order for the first two lines has to match the order in functions_validate.php, or your settings will get swapped around into the wrong variables.

[baerenwurm]

That solved the problem - thanks a lot!

[Patrick]

Nice job, Jeremy.