[Solved] 2.0.23 - Bug in escaping characters in PMs ?

[Quiff Boy]

i recently upgraded from 2.0.21 which i'd been running for years to .22 and then to .23 using the code changes posted on here

however, since the upgrade my users have spotted a bug

to recreate it:

1) view a pm from your inbox
2) hit the 'quote' button

at this point the quoted message still says:

Code: Select all

[quote="username"]message here[/quote]

3) preview your reply, including the original quoted message

now, instead of the expected:

Code: Select all

[quote="username"]message here[/quote]

you see this:

Code: Select all

[quote="username"]message here[/quote]

the quote mark is being replaced with the html entity for quotes... it looks like there's some character escaping/replacing going on when your preview the PM reply, and that it's not working quite correctly

note: this is only in the PM system (so is probably not to do with posting.php - more likely privmsg.php) and it happens in all browsers (which i take as further proof that it's not related to any of the javascript code in posting.php)

any ideas?

could it be related to line 39 from privmsg.php ?

Code: Select all

$html_entities_replace = array('&', '<', '>', '"');

EDIT
apologies, i think i've solved this now.

i downloaded a fresh copy 2.0.23 and ran a 'diff' on privmsg.php

i spotted a couple of instances where there was character escaping in my version that wasn't in the 'clean' version, so i removed the offending code and it seems ok now

no idea where the extra lines of code came from, but it's gone now

i have my users trying to recreate the bug but early signs are good.

sorry for the false alarm

[Patrick]

No worries. Glad that you got it sorted.

Thanks,

Patrick